fix(update): actually update the local file and not a global install#268
Closed
MorganVonBrylan wants to merge 2 commits intomicrolinkhq:masterfrom
Closed
fix(update): actually update the local file and not a global install#268MorganVonBrylan wants to merge 2 commits intomicrolinkhq:masterfrom
MorganVonBrylan wants to merge 2 commits intomicrolinkhq:masterfrom
Conversation
Member
|
I promoted the change in this way: wdyt? |
Contributor
Author
|
The reason I had separated the working directory and the filename was so tinyspawn wouldn't crash if there is a space in the path, but I suppose fixing this issue here doesn't do much if it isn't also fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's entirely my bad, I didn't properly pay attention while testing.
The
updatefunction actually tries to update the globally-installed yt-dlp and not oneyoutube-dl-execdownloaded. THe mistake lied in just two small characters..../